Skip to content

Conversation

@kadubhumika
Copy link

✨ What’s New

  • Added a new JetCoDatePicker composable under components/datepicker/.
  • Created a basic preview in the demo kmp module to showcase it.
  • This component allows users to select a date (simple UI for now, expandable for calendar view).

🧠 Future Scope

  • Add proper calendar grid UI and month navigation.
  • Theme integration for JetCo color palette.

@kadubhumika
Copy link
Author

Sir @developerchunk , I’ve created a simple Date Picker UI. I faced some issues while creating a new Kotlin file—it wasn’t showing as Kotlin initially—so I took help by creating a file and manually adding the .kt extension, which worked. However, I wasn’t able to see the preview or run the app. I’m not sure if I need to set up my own configuration for this, or if it’s already set up in the project.

Please take a look at my code. If you think it needs more, I can enhance it to include a proper UI and all relevant features. I would also appreciate any suggestions on how to proceed further regarding the preview/run issue.

@developerchunk
Copy link
Owner

Hello @kadubhumika 👋

Thank you for your contribution! We truly appreciate each and every contribution you make towards JetCo and the Open-Source Community. 💜

I’ve reviewed your code and tested it locally — below are a few issues and suggestions that you can work on. I’ve also added notes at the end about the project structure and how you can run and test your component.


⚠️ Issues Identified

  • The JetCoDatePicker component requires a minimum Android SDK 26 (Android 8.0), but our library currently supports min SDK 21, so it’s not compatible as-is.
  • The component uses various Java imports for handling time and utilities, which causes issues during KMP migration. Please switch to Kotlin-only libraries and imports.
  • The current Date Picker does not include a Year selection option.
  • The Date Picker always starts the month from Monday, which isn’t correct — the 1st date of each month varies depending on the month and year.
  • The component currently lacks customization options (e.g., parameters for font, color, border, or providing custom composables). Please make it more flexible for developers.
  • The JetCoDatePicker is not responsive for landscape or larger screens.
  • Consider wrapping the Date Picker inside an AlertDialog, but make this optional so users can choose whether to use a dialog or not.
  • The UI looks quite basic — feel free to add your own creative touch! You can take inspiration from Dribbble or Behance.

🧪 How to Test Your Component

The repository contains two separate projects:

  1. JetCo KMP
  2. JetCo Android

Please open them in separate windows in IntelliJ IDEA or Android Studio.

  • For Android: call your component inside the app module.
  • For KMP: call your component inside the composeApp module.

You’ll notice that jetco is a separate module in both projects — we follow a multi-module architecture.


✅ Next Steps

Once you’ve made the required changes, you can:

  • Push the updates to the same PR, or
  • Create a new fresh PR for better clarity.

Thank you once again for your effort and contribution! 🙌
Also, no need to use any prefixes like sir or ma’am — just a mention is enough. 😄

@kadubhumika
Copy link
Author

kadubhumika commented Oct 24, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants